TimelineItemPresenterFactories #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DI infrastructure to allow injection of presenters into the timeline. Add an @AssisteFactory of type `TimelineItemPresenterFactory` to a [Presenter] class and bind this factory ino the TimelineItemPresenterFactory map multi binding using: ``` @BINDS @Intomap @TimelineItemEventContentKey(MyTimelineItemContent::class) ``` A map multibinding of such map will be available in the `LocalTimelineItemPresenterFactories` composition local for further use down the UI tree.
7 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1609 +/- ##
===========================================
- Coverage 58.94% 58.92% -0.02%
===========================================
Files 1201 1202 +1
Lines 30982 30989 +7
Branches 6345 6345
===========================================
Hits 18261 18261
- Misses 9974 9981 +7
Partials 2747 2747
☔ View full report in Codecov by Sentry. |
ganfra
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DI infrastructure to allow injection of presenters into the timeline. Add an @AssisteFactory of type
TimelineItemPresenterFactoryto a [Presenter] class and bind this factory ino the TimelineItemPresenterFactory map multi binding using:A map multibinding of such map will be available in the
LocalTimelineItemPresenterFactoriescomposition local for further use down the UI tree.