Custom room notification settings list #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get roomsWithUserDefinedRules from rust - add to state in the presenter - render in the edit defaults view as a list
- List user define room notification settings - Add new user defined style of the room notification settings view - Add navigation to expose room notification settings ui to the global settings - Add Progress indicators - Improve error handing
…ttps://github.com/vector-im/element-x-android into dla/feature/custom_room_notification_settings_list
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1610 +/- ##
===========================================
+ Coverage 63.01% 63.04% +0.02%
===========================================
Files 1183 1188 +5
Lines 30440 30723 +283
Branches 6293 6342 +49
===========================================
+ Hits 19183 19368 +185
- Misses 8377 8435 +58
- Partials 2880 2920 +40
☔ View full report in Codecov by Sentry. |
- Add new ui for room notifications screen - Fix error when changing default notification setting.
…tps://github.com/vector-im/element-x-android into dla/feature/room_notification_settings_ui_update
…o dla/feature/room_notification_settings_ui_update
julioromano
reviewed
Oct 24, 2023
...ement/android/features/roomdetails/impl/notificationsettings/RoomNotificationSettingsNode.kt
Outdated
Show resolved
Hide resolved
julioromano
approved these changes
Oct 24, 2023
...otlin/io/element/android/features/preferences/impl/notifications/NotificationSettingsView.kt
Show resolved
Hide resolved
.../features/preferences/impl/notifications/edit/EditDefaultNotificationSettingStateProvider.kt
Show resolved
Hide resolved
- Add additional states to preview. - Add TODO description for commented code - Move showUserDefinedSettingStyle from the node to the view for testability.
…ttps://github.com/vector-im/element-x-android into dla/feature/room_notification_settings_ui_update
…_settings_ui_update Room notification settings UI update
…ttps://github.com/vector-im/element-x-android into dla/feature/custom_room_notification_settings_list
|
Kudos, SonarCloud Quality Gate passed!
|
langleyd
deleted the
dla/feature/custom_room_notification_settings_list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #536
Fixes #1567 (Mostly, will only be fully corrected by the arrival of MSC3934)
Content
Screenshots / GIFs
screen-20231019-080425.mp4