Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppNameProvider, we have buildMeta now. #1614

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 20, 2023

Small cleanup PR.

@bmarty bmarty requested a review from a team as a code owner October 20, 2023 08:42
@bmarty bmarty requested review from ganfra and removed request for a team October 20, 2023 08:42
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YA45V5

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0664f01) 58.82% compared to head (510bdd4) 58.84%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1614      +/-   ##
===========================================
+ Coverage    58.82%   58.84%   +0.02%     
===========================================
  Files         1222     1221       -1     
  Lines        31438    31427      -11     
  Branches      6443     6442       -1     
===========================================
  Hits         18493    18493              
+ Misses       10145    10134      -11     
  Partials      2800     2800              
Files Coverage Δ
...ment/android/libraries/push/impl/PushersManager.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty
Copy link
Member Author

bmarty commented Oct 20, 2023

Maestro issue fixed in #1615

@bmarty bmarty merged commit 8aa706e into develop Oct 20, 2023
14 of 17 checks passed
@bmarty bmarty deleted the feature/bma/removeAppNameProvider branch October 20, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants