Fix issue where text is cleared when cancelling a reply

[jonnyandrew]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Fix issue where text is cleared when cancelling a reply.

Also remove redundant property on the MessageComposerMode.Normal class.

Motivation and context

• Fixes Message input box is cleared after cancelling a reply #1561

Screenshots / GIFs

N/A

Tests

• Start replying to a message
• Click the x button to cancel the reply
• Observe text is not cleared

Tested devices

• Physical
• Emulator
• OS version(s): 13

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[jonnyandrew]

Here is the fix

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yynLaV

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8aa706e) 58.98% compared to head (0d094fa) 58.98%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1617   +/-   ##
========================================
  Coverage    58.98%   58.98%           
========================================
  Files         1225     1225           
  Lines        31619    31619           
  Branches      6493     6494    +1     
========================================
  Hits         18652    18652           
  Misses       10143    10143           
  Partials      2824     2824           

Files	Coverage Δ
...id/features/messages/impl/MessagesStateProvider.kt	90.69% <100.00%> (ø)
...impl/messagecomposer/MessageComposerContextImpl.kt	100.00% <100.00%> (ø)
...s/impl/messagecomposer/MessageComposerPresenter.kt	92.97% <100.00%> (+0.03%)	⬆️
...pl/messagecomposer/MessageComposerStateProvider.kt	95.23% <100.00%> (ø)
...atures/messages/test/MessageComposerContextFake.kt	100.00% <100.00%> (ø)
...ent/android/libraries/textcomposer/TextComposer.kt	80.47% <ø> (ø)
...id/libraries/textcomposer/components/SendButton.kt	81.08% <ø> (ø)
...ibraries/textcomposer/model/MessageComposerMode.kt	95.00% <ø> (-0.24%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Thanks for the fix and for having added a test for it!