Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress indicator for sending voice messages #1618

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 20, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add progress indicator for sending voice messages.

Motivation and context

Screenshots / GIFs

Tests

  • Enable voice messages in dev settings
  • Record and send a voice message

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 20, 2023 16:10
@jonnyandrew jonnyandrew requested review from julioromano and removed request for a team October 20, 2023 16:10
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/utgojN

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b476654) 59.21% compared to head (b2a189e) 59.24%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1618      +/-   ##
===========================================
+ Coverage    59.21%   59.24%   +0.02%     
===========================================
  Files         1246     1246              
  Lines        32268    32285      +17     
  Branches      6618     6627       +9     
===========================================
+ Hits         19109    19127      +18     
+ Misses       10289    10286       -3     
- Partials      2870     2872       +2     
Files Coverage Δ
...mpl/voicemessages/VoiceMessageComposerPresenter.kt 93.97% <100.00%> (+0.14%) ⬆️
...ies/textcomposer/components/VoiceMessagePreview.kt 77.27% <100.00%> (+3.58%) ⬆️
.../libraries/textcomposer/model/VoiceMessageState.kt 100.00% <100.00%> (ø)
...ent/android/libraries/textcomposer/TextComposer.kt 78.70% <68.75%> (+1.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew force-pushed the jonny/voice-message-sending-progress branch 2 times, most recently from 78c2e9d to b5899cc Compare October 23, 2023 16:25
@jonnyandrew jonnyandrew force-pushed the jonny/voice-message-sending-progress branch from b5899cc to 954cdbb Compare October 23, 2023 16:40
Base automatically changed from jonny/voice-message-sending to develop October 23, 2023 17:28
@jonnyandrew jonnyandrew force-pushed the jonny/voice-message-sending-progress branch from 3dddda2 to b2a189e Compare October 23, 2023 19:45
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew merged commit 8c0d9cc into develop Oct 24, 2023
16 of 17 checks passed
@jonnyandrew jonnyandrew deleted the jonny/voice-message-sending-progress branch October 24, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants