Room notification settings UI update #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new ui for room notifications screen - Fix error when changing default notification setting.
langleyd
changed the base branch from
develop
to
dla/feature/custom_room_notification_settings_list
|
Adding @julioromano as a reviewer as this is is based of the branch in #1610. |
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dla/feature/custom_room_notification_settings_list #1621 +/- ##
======================================================================================
- Coverage 59.01% 58.99% -0.03%
======================================================================================
Files 1192 1208 +16
Lines 30844 31315 +471
Branches 6338 6407 +69
======================================================================================
+ Hits 18204 18474 +270
- Misses 9896 10046 +150
- Partials 2744 2795 +51
☔ View full report in Codecov by Sentry. |
…tps://github.com/vector-im/element-x-android into dla/feature/room_notification_settings_ui_update
…o dla/feature/room_notification_settings_ui_update
|
Kudos, SonarCloud Quality Gate passed!
|
bmarty
reviewed
Oct 24, 2023
...roid/features/preferences/impl/notifications/edit/EditDefaultNotificationSettingPresenter.kt
Outdated
Show resolved
Hide resolved
julioromano
approved these changes
Oct 24, 2023
...ils/api/src/main/kotlin/io/element/android/features/roomdetails/api/RoomDetailsEntryPoint.kt
Show resolved
Hide resolved
...roid/features/preferences/impl/notifications/edit/EditDefaultNotificationSettingPresenter.kt
Outdated
Show resolved
Hide resolved
…ttps://github.com/vector-im/element-x-android into dla/feature/room_notification_settings_ui_update
langleyd
merged commit 0e6f762
into
dla/feature/custom_room_notification_settings_list
5 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #508
Content
Updates the room notifications settings as outlined by design to be more like iOS. Figma
Also fixes a bug where changing the default room notification mode in the global settings fails with an error and leaves the push rules in a mismatched state.
Screenshots / GIFs
screen-20231020-210655.mp4