Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Strings #1623

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Sync Strings #1623

merged 4 commits into from
Oct 23, 2023

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot requested a review from a team as a code owner October 23, 2023 00:09
@ElementBot ElementBot requested review from jmartinesp and removed request for a team October 23, 2023 00:09
@ElementBot
Copy link
Collaborator Author

ElementBot commented Oct 23, 2023

Warnings
⚠️

features/lockscreen/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L187 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L192 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L198 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L203 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L208 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 842c1ed

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7Ys5hv

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (244c457) 58.96% compared to head (8e4ca83) 58.96%.
Report is 1 commits behind head on develop.

❗ Current head 8e4ca83 differs from pull request most recent head 842c1ed. Consider uploading reports for the commit 842c1ed to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1623   +/-   ##
========================================
  Coverage    58.96%   58.96%           
========================================
  Files         1225     1225           
  Lines        31631    31631           
  Branches      6497     6497           
========================================
  Hits         18652    18652           
  Misses       10154    10154           
  Partials      2825     2825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some changes to the translations and adding some new screenshots.

@jmartinesp jmartinesp enabled auto-merge (squash) October 23, 2023 07:53
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jmartinesp jmartinesp merged commit c8dc364 into develop Oct 23, 2023
14 of 15 checks passed
@jmartinesp jmartinesp deleted the sync-localazy branch October 23, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants