-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emoji shortcut values #1625
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Recording screenshot: https://github.com/vector-im/element-x-android/actions/runs/6612914842 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1625 +/- ##
========================================
Coverage 58.96% 58.96%
========================================
Files 1225 1225
Lines 31631 31631
Branches 6498 6498
========================================
Hits 18652 18652
Misses 10154 10154
Partials 2825 2825
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the screenshot? the highlighted emoji is not there anymore as I guess it has to be updated too in the aTimelineItemReactions
method
…om/vector-im/element-x-android into langleyd/fix_emoji_shortcut_values
Kudos, SonarCloud Quality Gate passed! |
Fixes #1585
Content
The emoji shortcut values in the action list should match those that come from emojibase/unicode spec. I believe the existing ones are missing the emoji variation selector codepoint.