Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emoji shortcut values #1625

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Conversation

langleyd
Copy link
Contributor

Fixes #1585

Content

The emoji shortcut values in the action list should match those that come from emojibase/unicode spec. I believe the existing ones are missing the emoji variation selector codepoint.

@langleyd langleyd requested a review from a team as a code owner October 23, 2023 11:10
@langleyd langleyd requested review from ganfra and removed request for a team October 23, 2023 11:10
@ElementBot
Copy link
Collaborator

ElementBot commented Oct 23, 2023

Warnings
⚠️

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt#L37 - Using a material import while also using the material3 library

⚠️

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt#L38 - Using a material import while also using the material3 library

Generated by 🚫 dangerJS against 7e6cc4d

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pKMZL3

@bmarty
Copy link
Member

bmarty commented Oct 23, 2023

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7048da2) 58.96% compared to head (7e6cc4d) 58.96%.
Report is 26 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1625   +/-   ##
========================================
  Coverage    58.96%   58.96%           
========================================
  Files         1225     1225           
  Lines        31631    31631           
  Branches      6498     6498           
========================================
  Hits         18652    18652           
  Misses       10154    10154           
  Partials      2825     2825           
Files Coverage Δ
...eatures/messages/impl/actionlist/ActionListView.kt 59.47% <100.00%> (ø)
...es/messages/impl/timeline/TimelineStateProvider.kt 98.98% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the screenshot? the highlighted emoji is not there anymore as I guess it has to be updated too in the aTimelineItemReactions method

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@langleyd langleyd merged commit 503efbf into develop Oct 23, 2023
17 checks passed
@langleyd langleyd deleted the langleyd/fix_emoji_shortcut_values branch October 23, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom sheet "emojis shortcuts" have incorrect unicode value(different from emojibase).
4 participants