Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tracing of matrix_sdk_ui::timeline to trace #1630

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jmartinesp
Copy link
Contributor

Requested by the Rust team do try to debug the gaps in the timeline reported by some users.

@jmartinesp jmartinesp requested a review from a team as a code owner October 24, 2023 07:35
@jmartinesp jmartinesp requested review from bmarty and removed request for a team October 24, 2023 07:35
Copy link
Contributor

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Related issue: #1076

@jmartinesp jmartinesp enabled auto-merge (squash) October 24, 2023 07:37
@jmartinesp jmartinesp merged commit fc8d166 into develop Oct 24, 2023
12 checks passed
@jmartinesp jmartinesp deleted the misc/jme/change-timeline-tracing-level branch October 24, 2023 07:37
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3bScZL

@bmarty
Copy link
Member

bmarty commented Oct 24, 2023

This change also impacts the release version. It was already possible to tweak this tracing in the developer option, in the debug builds. This was not enough?

@jplatte
Copy link
Contributor

jplatte commented Oct 24, 2023

I don't think we should burden external people with going to developer options when reporting bugs. It's there for us, when we are trying specific reproduction steps. However, the timeline gap bugs have been very hard to reproduce.

@bmarty
Copy link
Member

bmarty commented Oct 24, 2023

OK, fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants