Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BackupState and BackupStateMapper #1632

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 24, 2023

Add BackupState and BackupStateMapper from the feature/bma/secureBackup branch to ensure that we do not upgrade the SDK with no support of KeyBackup.

This will act as a poison pill to avoid mistake when building new version of the SDK.

…eBackup` branch to ensure that we do not upgrade the SDK with no support of KeyBackup.

This will act as a poison pill to avoid mistake when building new version of the SDK.
@bmarty bmarty requested a review from a team as a code owner October 24, 2023 09:12
@bmarty bmarty requested review from julioromano and removed request for a team October 24, 2023 09:12
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (8c0d9cc) 59.24% compared to head (04ed06c) 59.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1632      +/-   ##
===========================================
- Coverage    59.24%   59.21%   -0.04%     
===========================================
  Files         1246     1248       +2     
  Lines        32286    32304      +18     
  Branches      6627     6628       +1     
===========================================
  Hits         19128    19128              
- Misses       10286    10304      +18     
  Partials      2872     2872              
Files Coverage Δ
...oid/libraries/matrix/api/encryption/BackupState.kt 0.00% <0.00%> (ø)
...raries/matrix/impl/encryption/BackupStateMapper.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VM5Qew

@bmarty bmarty merged commit 0b98432 into develop Oct 24, 2023
13 of 17 checks passed
@bmarty bmarty deleted the feature/bma/backupMapper branch October 24, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants