Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package of voice message composer #1633

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Move package of voice message composer.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 24, 2023 11:59
@jonnyandrew jonnyandrew requested review from jmartinesp and removed request for a team October 24, 2023 11:59
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/op2ANd

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1b142f) 59.26% compared to head (47c5046) 59.26%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1633   +/-   ##
========================================
  Coverage    59.26%   59.26%           
========================================
  Files         1248     1248           
  Lines        32309    32309           
  Branches      6632     6632           
========================================
  Hits         19147    19147           
  Misses       10288    10288           
  Partials      2874     2874           
Files Coverage Δ
...ndroid/features/messages/impl/MessagesPresenter.kt 83.06% <ø> (ø)
...nt/android/features/messages/impl/MessagesState.kt 100.00% <ø> (ø)
...id/features/messages/impl/MessagesStateProvider.kt 90.90% <ø> (ø)
...ent/android/features/messages/impl/MessagesView.kt 57.38% <ø> (ø)
...ssages/impl/messagecomposer/MessageComposerView.kt 68.33% <ø> (ø)
...icemessages/composer/VoiceMessageComposerEvents.kt 100.00% <ø> (ø)
...messages/composer/VoiceMessageComposerPresenter.kt 94.11% <ø> (ø)
...oicemessages/composer/VoiceMessageComposerState.kt 100.00% <ø> (ø)
...ages/composer/VoiceMessageComposerStateProvider.kt 87.50% <ø> (ø)
.../composer/VoiceMessagePermissionRationaleDialog.kt 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew merged commit 9b027fc into develop Oct 24, 2023
16 checks passed
@jonnyandrew jonnyandrew deleted the jonny/voice-message-packaging branch October 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants