Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage #1634

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Code coverage #1634

merged 6 commits into from
Oct 24, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 24, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Imporve code covergage: add missing unit test and screenshot test.
Also ignore matrix impl lib, since it contains only wrappers and mappers. They are covered by Maestro test.

Motivation and context

Improve code coverage metrics.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner October 24, 2023 14:03
@bmarty bmarty requested review from ganfra and removed request for a team October 24, 2023 14:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MCLuJm

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9b027fc) 59.22% compared to head (02982b6) 62.99%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1634      +/-   ##
===========================================
+ Coverage    59.22%   62.99%   +3.76%     
===========================================
  Files         1250     1182      -68     
  Lines        32327    30383    -1944     
  Branches      6633     6277     -356     
===========================================
- Hits         19147    19140       -7     
+ Misses       10306     8371    -1935     
+ Partials      2874     2872       -2     
Files Coverage Δ
...id/features/messages/impl/MessagesStateProvider.kt 92.45% <100.00%> (+1.54%) ⬆️
...ages/composer/VoiceMessageComposerStateProvider.kt 88.88% <100.00%> (+1.38%) ⬆️
...tures/roomdetails/impl/RoomDetailsStateProvider.kt 96.22% <100.00%> (+0.14%) ⬆️
...droid/features/roomdetails/impl/RoomDetailsView.kt 60.00% <ø> (+3.50%) ⬆️
.../element/android/libraries/matrix/test/TestData.kt 100.00% <100.00%> (ø)
.../timeline/components/customreaction/EmojiPicker.kt 58.97% <0.00%> (+12.82%) ⬆️
...pl/timeline/components/customreaction/EmojiItem.kt 76.19% <76.19%> (ø)

... and 72 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit c04f95e into develop Oct 24, 2023
15 of 16 checks passed
@bmarty bmarty deleted the feature/bma/codeCoverage branch October 24, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants