Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting a recorded voice message #1635

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Allow deleting a recorded voice message before sending.

Motivation and context

Screenshots / GIFs

Tests

  • Record a voice message
  • Delete it before sending

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 24, 2023 15:23
@jonnyandrew jonnyandrew requested review from bmarty and removed request for a team October 24, 2023 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VbqeW3

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! One remark about the Fake class.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (9b027fc) 59.22% compared to head (a33aeaa) 59.25%.
Report is 8 commits behind head on develop.

❗ Current head a33aeaa differs from pull request most recent head 26330cc. Consider uploading reports for the commit 26330cc to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1635      +/-   ##
===========================================
+ Coverage    59.22%   59.25%   +0.02%     
===========================================
  Files         1250     1251       +1     
  Lines        32327    32384      +57     
  Branches      6633     6651      +18     
===========================================
+ Hits         19147    19189      +42     
- Misses       10306    10313       +7     
- Partials      2874     2882       +8     
Files Coverage Δ
...icemessages/composer/VoiceMessageComposerEvents.kt 100.00% <100.00%> (ø)
...messages/composer/VoiceMessageComposerPresenter.kt 94.18% <100.00%> (+0.06%) ⬆️
...ssages/impl/messagecomposer/MessageComposerView.kt 68.75% <80.00%> (+0.41%) ⬆️
.../libraries/voicerecorder/test/FakeVoiceRecorder.kt 92.10% <90.90%> (-0.49%) ⬇️
...ent/android/libraries/textcomposer/TextComposer.kt 78.42% <71.42%> (-0.28%) ⬇️
...extcomposer/components/VoiceMessageDeleteButton.kt 61.90% <61.90%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew enabled auto-merge (squash) October 24, 2023 20:56
@jonnyandrew jonnyandrew merged commit 8c7a0c0 into develop Oct 24, 2023
13 checks passed
@jonnyandrew jonnyandrew deleted the jonny/voice-message-delete branch October 24, 2023 21:02
@bmarty
Copy link
Member

bmarty commented Oct 25, 2023

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants