-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deleting a recorded voice message #1635
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! One remark about the Fake class.
...er/test/src/main/kotlin/io/element/android/libraries/voicerecorder/test/FakeVoiceRecorder.kt
Outdated
Show resolved
Hide resolved
...er/test/src/main/kotlin/io/element/android/libraries/voicerecorder/test/FakeVoiceRecorder.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1635 +/- ##
===========================================
+ Coverage 59.22% 59.25% +0.02%
===========================================
Files 1250 1251 +1
Lines 32327 32384 +57
Branches 6633 6651 +18
===========================================
+ Hits 19147 19189 +42
- Misses 10306 10313 +7
- Partials 2874 2882 +8
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
Thanks for the update! |
Type of change
Content
Allow deleting a recorded voice message before sending.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist