Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice message bubble design improvements #1637

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

julioromano
Copy link
Contributor

  • Fixes color and size of both text and icons.

- Fixes color and size of both text and icons.
@julioromano julioromano self-assigned this Oct 25, 2023
@julioromano julioromano requested a review from a team as a code owner October 25, 2023 14:44
@julioromano julioromano requested review from jmartinesp and removed request for a team October 25, 2023 14:44
@julioromano
Copy link
Contributor Author

@jmartinesp
Copy link
Contributor

jmartinesp commented Oct 25, 2023

I think something broke in the screenshots? Some screenshots were deleted, others added, other apparently renamed... There's no easy way to diff the changes like this. A couple of days ago the same happened in another PR of mine. Maybe the StateProvider already has too many states and we should think about splitting it?

Could this be caused by #1636?

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julioromano
Copy link
Contributor Author

I think something broke in the screenshots? Some screenshots were deleted, others added, other apparently renamed... There's no easy way to diff the changes like this. A couple of days ago the same happened in another PR of mine. Maybe the StateProvider already has too many states and we should think about splitting it?

Could this be caused by #1636?

The changes are indeed there and visible in the screenshots.
Though there is also a lot of noise (as in screenshots that don't belong to something that changed in this PR).
Unfortunately you won't see any waveforms in these sshots because the library we're currently using to generate it doesn't paint on first pass so the screenshots are blank.

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4hgUjj

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 158 lines in your changes are missing coverage. Please review.

Comparison is base (f5999a5) 63.19% compared to head (f8a06eb) 63.21%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1637      +/-   ##
===========================================
+ Coverage    63.19%   63.21%   +0.01%     
===========================================
  Files         1189     1201      +12     
  Lines        30796    31199     +403     
  Branches      6361     6446      +85     
===========================================
+ Hits         19463    19721     +258     
- Misses        8410     8518     +108     
- Partials      2923     2960      +37     
Files Coverage Δ
...eatures/messages/impl/actionlist/ActionListView.kt 59.64% <100.00%> (+0.17%) ⬆️
...line/factories/event/TimelineItemContentFactory.kt 56.00% <100.00%> (ø)
...ures/messages/impl/timeline/groups/Groupability.kt 59.25% <100.00%> (+1.56%) ⬆️
...l/timeline/model/event/TimelineItemVoiceContent.kt 100.00% <100.00%> (ø)
...ne/model/event/TimelineItemVoiceContentProvider.kt 100.00% <100.00%> (ø)
.../impl/voicemessages/timeline/VoiceMessageEvents.kt 100.00% <100.00%> (ø)
...s/impl/voicemessages/timeline/VoiceMessageState.kt 100.00% <100.00%> (ø)
...ndroid/features/messages/impl/MessagesPresenter.kt 82.63% <0.00%> (-0.44%) ⬇️
...l/timeline/model/event/TimelineItemEventContent.kt 91.66% <50.00%> (-3.79%) ⬇️
...tils/messagesummary/MessageSummaryFormatterImpl.kt 50.00% <0.00%> (-3.34%) ⬇️
... and 11 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in code LGTM, although I'm quite worried about the auto-incremented values in the screenshot names...

@julioromano julioromano merged commit 9cf17df into develop Oct 25, 2023
15 of 16 checks passed
@julioromano julioromano deleted the julioromano/vm_tweaks branch October 25, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants