-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice message bubble design improvements #1637
Conversation
julioromano
commented
Oct 25, 2023
- Fixes color and size of both text and icons.
- Fixes color and size of both text and icons.
I think something broke in the screenshots? Some screenshots were deleted, others added, other apparently renamed... There's no easy way to diff the changes like this. A couple of days ago the same happened in another PR of mine. Maybe the StateProvider already has too many states and we should think about splitting it? Could this be caused by #1636? |
Kudos, SonarCloud Quality Gate passed! |
The changes are indeed there and visible in the screenshots. |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1637 +/- ##
===========================================
+ Coverage 63.19% 63.21% +0.01%
===========================================
Files 1189 1201 +12
Lines 30796 31199 +403
Branches 6361 6446 +85
===========================================
+ Hits 19463 19721 +258
- Misses 8410 8518 +108
- Partials 2923 2960 +37
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in code LGTM, although I'm quite worried about the auto-incremented values in the screenshot names...