-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the chat screen UI using RoomInfo. #1640
Conversation
This is specially useful for getting live values for `hasRoomCall`.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1640 +/- ##
===========================================
- Coverage 63.21% 62.99% -0.22%
===========================================
Files 1201 1203 +2
Lines 31199 30933 -266
Branches 6446 6377 -69
===========================================
- Hits 19721 19487 -234
+ Misses 8518 8509 -9
+ Partials 2960 2937 -23
☔ View full report in Codecov by Sentry. |
a3e29e9
to
64d42fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Icon( | ||
modifier = Modifier.size(20.dp), | ||
resourceId = CommonDrawables.ic_compound_video_call, | ||
contentDescription = stringResource(CommonStrings.action_join) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A11y: Since there is a text in the button, with the same string, I think the contentDescription can be null here.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This is specially useful for getting live values for
hasRoomCall
.Type of change
Content
roomInfoFlow
toMatrixRoom
to getMatrixRoomInfo
updates in real time.RoomInfo
to get live updates.Motivation and context
Implements most of #1158.
Screenshots / GIFs
In the PR.
Tests
You can take a look at the screenshots or:
Tested devices
Checklist