Add custom waveform with cursor and nice gesture support. #1641
Conversation
-Remove WaveformProgressIndicator - Remove waveform library - lint.
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1641 +/- ##
===========================================
+ Coverage 63.20% 63.22% +0.02%
===========================================
Files 1201 1202 +1
Lines 31207 31279 +72
Branches 6447 6458 +11
===========================================
+ Hits 19724 19777 +53
- Misses 8523 8537 +14
- Partials 2960 2965 +5
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
| (canvasSize.width.value / (lineWidth.value + linePadding.value)).toInt() | ||
| } | ||
| } | ||
| val normalizedWaveformData by remember(amplitudeDisplayCount) { |
There was a problem hiding this comment.
shouldn't you want to key waveform too?
In theory if the waveform changes we should also recompute the normalized data, in practice it will never happen though (the whole timeline item will change instead).
There was a problem hiding this comment.
Yes good point, I had the same question, this was actually part of the port of form iOS. I'll check with them on that.
There was a problem hiding this comment.
The count can change based on the width of the screen, but we don't expect the estimated waveform to change as it comes from the event.
Type of change
Content
A Custom waveform implementation with improved gesture support with the timeline and the green cursor added.
Motivation and context
Screenshots / GIFs
1000000004.mp4