-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIN : settings and branch flow #1642
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work, thanks!
@@ -111,6 +120,7 @@ internal fun PinEntryTextFieldPreview() { | |||
ElementPreview { | |||
PinEntryTextField( | |||
pinEntry = PinEntry.createEmpty(4).fillWith("12"), | |||
isSecured = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be nice to have 2 previews, maybe just wrap in a Column?
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR adds the
LockScreenSettingsNode
and branches all the screen to the regular flow.The feature is now only missing the biometric flow, which will come in the next PR.
Figma : https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?type=design&node-id=13067-149321&mode=dev