Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIN : settings and branch flow #1642

Merged
merged 24 commits into from
Oct 26, 2023
Merged

PIN : settings and branch flow #1642

merged 24 commits into from
Oct 26, 2023

Conversation

ganfra
Copy link
Contributor

@ganfra ganfra commented Oct 26, 2023

This PR adds the LockScreenSettingsNode and branches all the screen to the regular flow.
The feature is now only missing the biometric flow, which will come in the next PR.
Figma : https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?type=design&node-id=13067-149321&mode=dev

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fdMxpL

@ganfra ganfra marked this pull request as ready for review October 26, 2023 11:12
@ganfra ganfra requested a review from a team as a code owner October 26, 2023 11:12
@ganfra ganfra requested review from bmarty and removed request for a team October 26, 2023 11:12
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work, thanks!

@@ -111,6 +120,7 @@ internal fun PinEntryTextFieldPreview() {
ElementPreview {
PinEntryTextField(
pinEntry = PinEntry.createEmpty(4).fillWith("12"),
isSecured = true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to have 2 previews, maybe just wrap in a Column?

@ElementBot
Copy link
Collaborator

ElementBot commented Oct 26, 2023

Warnings
⚠️

features/lockscreen/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantities should also be defined: few (e.g. "2 dni"), many (e.g. "10.0 dňa"), one (e.g. "1 deň")

⚠️

features/lockscreen/impl/src/main/res/values-sk/translations.xml#L6 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

features/messages/impl/src/main/res/values-cs/translations.xml#L3 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

features/messages/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

features/roomdetails/impl/src/main/res/values-cs/translations.xml#L3 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

features/roomdetails/impl/src/main/res/values-ro/translations.xml#L3 - For locale "ro" (Romanian) the following quantity should also be defined: few (e.g. "2 zile")

⚠️

features/roomdetails/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L199 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L204 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L209 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 6d5ce88

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ganfra ganfra enabled auto-merge October 26, 2023 14:35
@ganfra ganfra merged commit ec9b6ba into develop Oct 26, 2023
13 checks passed
@ganfra ganfra deleted the feature/fga/pin_settings branch October 26, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants