Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of voice message playing code #1643

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

julioromano
Copy link
Contributor

After PR review suggestions from @jonnyandrew
User facing functionality doesn't change, but overall architecture and testing is better.

@julioromano julioromano self-assigned this Oct 26, 2023
@julioromano julioromano requested a review from a team as a code owner October 26, 2023 10:03
@julioromano julioromano requested review from jmartinesp and jonnyandrew and removed request for a team and jmartinesp October 26, 2023 10:03
Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thank you!

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HfRwrW

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (71ef76a) 63.21% compared to head (b96bb7e) 63.20%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1643      +/-   ##
===========================================
- Coverage    63.21%   63.20%   -0.01%     
===========================================
  Files         1201     1201              
  Lines        31199    31207       +8     
  Branches      6446     6447       +1     
===========================================
+ Hits         19721    19724       +3     
- Misses        8518     8523       +5     
  Partials      2960     2960              
Files Coverage Δ
...pl/voicemessages/timeline/VoiceMessagePresenter.kt 91.89% <100.00%> (-2.34%) ⬇️
...oid/libraries/matrix/test/media/FakeMediaLoader.kt 46.66% <100.00%> (+3.80%) ⬆️
...pl/voicemessages/timeline/VoiceMessageMediaRepo.kt 89.28% <89.28%> (ø)
.../impl/voicemessages/timeline/VoiceMessagePlayer.kt 72.34% <65.38%> (-0.64%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julioromano julioromano merged commit 7d1b671 into develop Oct 26, 2023
16 of 17 checks passed
@julioromano julioromano deleted the julioromano/better_player_cache_presenter branch October 26, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants