-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of voice message playing code #1643
Refactor of voice message playing code #1643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, thank you!
Kudos, SonarCloud Quality Gate passed! |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1643 +/- ##
===========================================
- Coverage 63.21% 63.20% -0.01%
===========================================
Files 1201 1201
Lines 31199 31207 +8
Branches 6446 6447 +1
===========================================
+ Hits 19721 19724 +3
- Misses 8518 8523 +5
Partials 2960 2960
☔ View full report in Codecov by Sentry. |
After PR review suggestions from @jonnyandrew
User facing functionality doesn't change, but overall architecture and testing is better.