Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice message preview player #1646

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add an audio player to the voice message preview.

Motivation and context

Screenshots / GIFs

Tests

  • Record a voice message
  • Play it back

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 26, 2023 12:58
@jonnyandrew jonnyandrew requested review from julioromano and removed request for a team October 26, 2023 12:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4dNwtK

@jonnyandrew jonnyandrew force-pushed the jonny/voice-message-preview-player branch from d19772a to d3a8e78 Compare October 26, 2023 13:34
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (3ec62ad) 63.22% compared to head (d3a8e78) 63.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1646      +/-   ##
===========================================
+ Coverage    63.22%   63.25%   +0.02%     
===========================================
  Files         1202     1204       +2     
  Lines        31279    31373      +94     
  Branches      6458     6476      +18     
===========================================
+ Hits         19777    19844      +67     
- Misses        8537     8555      +18     
- Partials      2965     2974       +9     
Files Coverage Δ
...icemessages/composer/VoiceMessageComposerEvents.kt 100.00% <100.00%> (ø)
.../libraries/textcomposer/model/VoiceMessageState.kt 100.00% <100.00%> (ø)
...ssages/impl/messagecomposer/MessageComposerView.kt 68.65% <66.66%> (-0.10%) ⬇️
...messages/composer/VoiceMessageComposerPresenter.kt 93.33% <88.88%> (-0.99%) ⬇️
...ries/textcomposer/model/VoiceMessagePlayerEvent.kt 60.00% <60.00%> (ø)
...ent/android/libraries/textcomposer/TextComposer.kt 78.37% <82.35%> (-0.06%) ⬇️
...icemessages/composer/VoiceMessageComposerPlayer.kt 68.00% <68.00%> (ø)
...ies/textcomposer/components/VoiceMessagePreview.kt 68.00% <66.66%> (-9.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew merged commit a67410f into develop Oct 26, 2023
15 of 16 checks passed
@jonnyandrew jonnyandrew deleted the jonny/voice-message-preview-player branch October 26, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants