-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure backup #1648
Secure backup #1648
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1648 +/- ##
===========================================
- Coverage 63.68% 63.64% -0.04%
===========================================
Files 1267 1267
Lines 32835 32881 +46
Branches 6796 6809 +13
===========================================
+ Hits 20910 20928 +18
- Misses 8789 8805 +16
- Partials 3136 3148 +12
☔ View full report in Codecov by Sentry. |
396215a
to
bc159b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Also, not directly related to this PR, but is it normal that I still see the encrypted history banner in the timeline after verifying my account and even confirming the recovery key?
d0e835d
to
2d2088c
Compare
(rebased and screenshooting again) |
Not really, I will investigate this. |
Error Error
Dangerfile
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The original big PR has been split to smaller one. This PR now include bug fixes and improvement.
Type of change
Content
First implementation of secure backup:
Figma: https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?node-id=12998%3A32971&mode=dev
Motivation and context
Fixes #1574
Fixes #1575
Fixes #1577
Fixes #1578
Screenshots / GIFs
See screenshot in the PR
Demo (including bugs)
Tests
Chat backup
setting entry and test all the new screens.Tested devices
Checklist