Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move waveform UI to design system library #1649

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Move waveform UI to design system library #1649

merged 2 commits into from
Oct 26, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 26, 2023 •
edited

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Move waveform UI to design system library.

Motivation and context

So that it can be accessed from libraries:textcomposer for use in voice recording UI.

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 26, 2023 13:31
@jonnyandrew jonnyandrew requested review from jmartinesp and removed request for a team October 26, 2023 13:31
bmarty
bmarty approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if CI is happy!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aGLqcD

@jonnyandrew jonnyandrew enabled auto-merge (squash) October 26, 2023 13:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew merged commit acd7aef into develop Oct 26, 2023
13 checks passed
@jonnyandrew jonnyandrew deleted the jonny/move-waveform-to-designsystem branch October 26, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@jmartinesp jmartinesp Awaiting requested review from jmartinesp jmartinesp is a code owner automatically assigned from element-hq/element-x-android-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonnyandrew @bmarty @ElementBot