Include waveform when sending voice messages #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julioromano
force-pushed
the
julioromano/send_waveform
branch
from
4687306
to
d767f1f
Compare
- New `AudioLevelCalculator` that outputs dB0v rescaled to the [0;1] range. - `VoiceRecorder` now stores the audio levels sampled while recording, then resamples them to 100 samples to use as waveform preview. - Waveform data is carried all the way as a `List<Float>` and converted to `List<Int>` in the [0;1024] range as per matrix spec only before sending it.
julioromano
force-pushed
the
julioromano/send_waveform
branch
from
d767f1f
to
ef9e448
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1650 +/- ##
===========================================
+ Coverage 63.01% 63.03% +0.02%
===========================================
Files 1204 1205 +1
Lines 31013 31039 +26
Branches 6389 6395 +6
===========================================
+ Hits 19543 19566 +23
Misses 8528 8528
- Partials 2942 2945 +3
☔ View full report in Codecov by Sentry. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AudioLevelCalculatorthat outputs dB0v rescaled to the [0;1] range.VoiceRecordernow stores the audio levels sampled while recording, then resamples them to 100 samples to use as waveform preview.List<Float>and converted toList<Int>in the [0;1024] range as per matrix spec only before sending it.