Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparatory work for SecureBackup: UI update #1651

Merged
merged 9 commits into from
Oct 27, 2023
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 26, 2023

Part of #1648: iteration on the design kit.

@bmarty bmarty requested a review from a team as a code owner October 26, 2023 15:12
@bmarty bmarty requested review from ganfra and removed request for a team October 26, 2023 15:12
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QmimK1

…o the composition from one source at their top level.
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (00d24ce) 63.06% compared to head (bf50476) 63.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1651      +/-   ##
===========================================
- Coverage    63.06%   63.05%   -0.01%     
===========================================
  Files         1215     1217       +2     
  Lines        31345    31402      +57     
  Branches      6447     6477      +30     
===========================================
+ Hits         19768    19801      +33     
- Misses        8604     8612       +8     
- Partials      2973     2989      +16     
Files Coverage Δ
...ces/impl/notifications/NotificationSettingsView.kt 50.49% <100.00%> (-8.71%) ⬇️
...ignsystem/components/preferences/PreferenceText.kt 92.23% <100.00%> (-0.84%) ⬇️
...mlist/impl/components/RequestVerificationHeader.kt 45.45% <83.33%> (-39.17%) ⬇️
...ignsystem/components/dialogs/ConfirmationDialog.kt 61.90% <75.00%> (-1.26%) ⬇️
...omponents/preferences/components/PreferenceIcon.kt 72.22% <83.33%> (+13.88%) ⬆️
...esignsystem/theme/components/AlertDialogContent.kt 75.10% <63.63%> (+0.54%) ⬆️
...ystem/atomic/molecules/DialogLikeBannerMolecule.kt 85.00% <85.00%> (ø)
...ries/designsystem/atomic/atoms/RedIndicatorAtom.kt 53.33% <53.33%> (ø)
.../libraries/designsystem/theme/components/Button.kt 78.22% <77.96%> (-1.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmarty bmarty merged commit bf905dd into develop Oct 27, 2023
14 of 17 checks passed
@bmarty bmarty deleted the feature/bma/uiUpdate branch October 27, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants