Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MediaPlayer from messages module to new dedicated library module #1654

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

julioromano
Copy link
Contributor

@julioromano julioromano commented Oct 26, 2023

No code changes. Just moves.

@julioromano julioromano self-assigned this Oct 26, 2023
@julioromano julioromano requested a review from a team as a code owner October 26, 2023 20:22
@julioromano julioromano requested review from bmarty and jonnyandrew and removed request for a team and bmarty October 26, 2023 20:22
@julioromano julioromano enabled auto-merge (squash) October 26, 2023 20:24
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mTFbmV

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0457e59) 63.05% compared to head (de05f12) 63.07%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1654      +/-   ##
===========================================
+ Coverage    63.05%   63.07%   +0.01%     
===========================================
  Files         1215     1217       +2     
  Lines        31342    31361      +19     
  Branches      6447     6447              
===========================================
+ Hits         19764    19782      +18     
- Misses        8605     8606       +1     
  Partials      2973     2973              
Files Coverage Δ
...icemessages/composer/VoiceMessageComposerPlayer.kt 68.00% <ø> (ø)
.../impl/voicemessages/timeline/VoiceMessagePlayer.kt 72.34% <ø> (ø)
...t/android/libraries/mediaplayer/api/MediaPlayer.kt 100.00% <100.00%> (ø)
...roid/libraries/mediaplayer/impl/MediaPlayerImpl.kt 0.00% <ø> (ø)
...android/libraries/mediaplayer/impl/SimplePlayer.kt 0.00% <ø> (ø)
...roid/libraries/mediaplayer/test/FakeMediaPlayer.kt 94.73% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@julioromano julioromano merged commit b5586cb into develop Oct 27, 2023
15 checks passed
@julioromano julioromano deleted the julioromano/move_media_player_to_lib branch October 27, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants