Show correct UI when replying to a voice message #1658
Conversation
julioromano
force-pushed
the
julioromano/reply_to_voice
branch
from
6b8dfba
to
142a17a
Compare
| ), | ||
| anActionListState().copy( | ||
| target = ActionListState.Target.Success( | ||
| event = aTimelineItemEvent(content = aTimelineItemVoiceContent()).copy( |
There was a problem hiding this comment.
There is no case with aTimelineItemFileContent anymore?
There was a problem hiding this comment.
whooops :) fixed
There was a problem hiding this comment.
Though I was also suprised there wasn't a aTimelineItemAudioContent
| is AudioMessageType -> { | ||
| when (type.isVoiceMessage) { | ||
| true -> true | ||
| false -> true |
There was a problem hiding this comment.
In the future we'll have to split AudioMessageType in two (AudioMessageType and VoiceMessageType).
When we do this having such structure in place might help a bit.
What do you think?
Should I actually split the message type right now?
There was a problem hiding this comment.
No worries, if there are plan to change this later :)
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1658 +/- ##
===========================================
+ Coverage 63.03% 63.08% +0.05%
===========================================
Files 1219 1219
Lines 31389 31420 +31
Branches 6450 6455 +5
===========================================
+ Hits 19786 19822 +36
+ Misses 8630 8625 -5
Partials 2973 2973
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Since @bmarty already gave his approval, I'll approve it now we have some screenshots. There are some missing for the room list and timeline, but we can add them in a separate PR.
Shows voice messages in the room summary.
Shows voice messages in the reply context menu and composer.
Show replies to voice messages in the timeline.
(before this PR voice messages were shown the same as audio messages)
Story: element-hq/element-meta#2106