Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live waveform #1659

Merged
merged 16 commits into from
Oct 27, 2023
Merged

Live waveform #1659

merged 16 commits into from
Oct 27, 2023

Conversation

langleyd
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Show a live waveform when the user is recording a voice message

Screenshots / GIFs

1000000006.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/83MREN

@langleyd langleyd marked this pull request as ready for review October 27, 2023 10:24
@langleyd langleyd requested a review from a team as a code owner October 27, 2023 10:24
@langleyd langleyd requested review from julioromano and removed request for a team October 27, 2023 10:24
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9510d43) 63.15% compared to head (5da40ab) 63.08%.
Report is 2 commits behind head on develop.

❗ Current head 5da40ab differs from pull request most recent head 52f0057. Consider uploading reports for the commit 52f0057 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1659      +/-   ##
===========================================
- Coverage    63.15%   63.08%   -0.08%     
===========================================
  Files         1228     1223       -5     
  Lines        31680    31450     -230     
  Branches      6524     6453      -71     
===========================================
- Hits         20009    19841     -168     
+ Misses        8672     8634      -38     
+ Partials      2999     2975      -24
Files Coverage Δ
...messages/composer/VoiceMessageComposerPresenter.kt 92.45% <100.00%> (-0.66%) ⬇️
...ages/composer/VoiceMessageComposerStateProvider.kt 90.00% <100.00%> (+1.11%) ⬆️
...ignsystem/components/media/WaveformPlaybackView.kt 65.85% <100.00%> (-1.93%) ⬇️
...ent/android/libraries/textcomposer/TextComposer.kt 78.37% <100.00%> (+0.80%) ⬆️
...s/textcomposer/components/VoiceMessageRecording.kt 75.75% <100.00%> (+1.33%) ⬆️
.../libraries/textcomposer/model/VoiceMessageState.kt 100.00% <100.00%> (ø)
.../libraries/voicerecorder/api/VoiceRecorderState.kt 100.00% <100.00%> (ø)
.../libraries/voicerecorder/impl/VoiceRecorderImpl.kt 94.02% <100.00%> (+0.80%) ⬆️
.../libraries/voicerecorder/test/FakeVoiceRecorder.kt 92.10% <50.00%> (-2.90%) ⬇️
...em/components/media/DrawScopeWaveformExtensions.kt 88.88% <88.88%> (ø)
... and 1 more

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

julioromano
julioromano approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, just some nits

...t/android/features/messages/impl/voicemessages/composer/VoiceMessageComposerStateProvider.kt Outdated Show resolved Hide resolved
.../textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt Outdated Show resolved Hide resolved
...er/impl/src/main/kotlin/io/element/android/libraries/voicerecorder/impl/VoiceRecorderImpl.kt
@@ -67,6 +69,7 @@ class VoiceRecorderImpl @Inject constructor(
private var audioReader: AudioReader? = null
private var recordingJob: Job? = null
private val levels: MutableList<Float> = mutableListOf()
private val lock = Mutex()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there some concurrency thing that led to crashes before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes a concurrency modification exception when calling toPersisentList() at a later point, as I was returning a list that was being modified, so some safety measures.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@langleyd langleyd merged commit 473c8ab into develop Oct 27, 2023
13 checks passed
@langleyd langleyd deleted the langleyd/live_waveform branch October 27, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julioromano julioromano julioromano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@langleyd @julioromano @ElementBot