Secure backup UI #1662
Secure backup UI #1662
Conversation
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1662 +/- ##
===========================================
+ Coverage 63.04% 63.50% +0.46%
===========================================
Files 1223 1260 +37
Lines 31465 32508 +1043
Branches 6480 6738 +258
===========================================
+ Hits 19837 20645 +808
- Misses 8639 8744 +105
- Partials 2989 3119 +130
☔ View full report in Codecov by Sentry. |
| var isLastSession by remember { mutableStateOf(false) } | ||
| LaunchedEffect(Unit) { | ||
| isLastSession = encryptionService.isLastDevice().getOrNull() ?: false | ||
| encryptionService.waitForBackupUploadSteadyState() |
There was a problem hiding this comment.
This is not part of this PR, but the API is kind of weird, couldn't we just return the encryptionService.backupUploadStateStateFlow in a single call, instead of collecting the value somewhere and starting the subscription somewhere else?
There was a problem hiding this comment.
Yes, I can try to improve this.
| @@ -195,6 +197,13 @@ private fun RoomListContent( | |||
| onDismissClicked = { state.eventSink(RoomListEvents.DismissRequestVerificationPrompt) } | |||
| ) | |||
| } | |||
| } else if (state.displayRecoveryKeyPrompt) { | |||
| val recoveryKeyVisualTransformation = remember { | ||
| RecoveryKeyVisualTransformation() | ||
| } | ||
| OutlinedTextField( |
There was a problem hiding this comment.
Nit: neither hardware nor software Enter key triggers the 'continue' action.
| onDone() | ||
| } | ||
| } | ||
| HeaderFooterPage( |
There was a problem hiding this comment.
Since there is no content, I guess there are no designs? I didn't see any in Figma.
There was a problem hiding this comment.
We have this: https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?node-id=12998%3A37632&mode=dev but maybe out of date...
| BottomMenu( | ||
| state = state, | ||
| onSaveClicked = { key -> | ||
| context.startSharePlainTextIntent( |
There was a problem hiding this comment.
Isn't it a bit weird to use a share intent? Does it allow you to download it to a file or just copy the key? I couldn't test this myself.
There was a problem hiding this comment.
It will propose to share the key as a String.
Remaining part of #1648 (see description there)
Screenshot are getting recorded.