Split VoiceMessageType from AudioMessageType
#1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Currently, for compatibility reasons, we implement MSC3245v1 which puts the voice data inside an audio message type.
Though at times it seems impractical to deal with a single message type which effectively represents 2 different kinds of messages.
This create a new message type called `VoiceMessageType` which is used whenever we receive an event with `"msgtype": "m.audio"` which also has the `"org.matrix.msc3245.voice": {}` field.
This makes it easier to process voice messages as different entities throughout the codebase.
julioromano
force-pushed
the
julioromano/split_audio_message_type
branch
from
bc1b061
to
db717e1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1664 +/- ##
===========================================
- Coverage 63.22% 63.21% -0.02%
===========================================
Files 1228 1228
Lines 31693 31706 +13
Branches 6526 6531 +5
===========================================
+ Hits 20039 20042 +3
- Misses 8656 8664 +8
- Partials 2998 3000 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for compatibility reasons, we implement MSC3245v1 which puts the voice data inside an audio message type. Though at times it seems impractical to deal with a single message type which effectively represents 2 different kinds of messages.
This PR creates a new message type called
VoiceMessageTypewhich is used whenever we receive an event with"msgtype": "m.audio"which also has the"org.matrix.msc3245.voice": {}field. This makes it easier to process voice messages as different entities throughout the rest of the codebase.