Track errors in VoiceMessagePresenter

[julioromano]

Story: element-hq/element-meta#2085

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nFtEFp

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a07286a) 63.24% compared to head (28bd8ad) 63.24%.

❗ Current head 28bd8ad differs from pull request most recent head f0d722c. Consider uploading reports for the commit f0d722c to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1667   +/-   ##
========================================
  Coverage    63.24%   63.24%           
========================================
  Files         1230     1230           
  Lines        31748    31751    +3     
  Branches      6534     6534           
========================================
+ Hits         20079    20082    +3     
  Misses        8667     8667           
  Partials      3002     3002           

Files	Coverage Δ
...ssages/impl/voicemessages/VoiceMessageException.kt	100.00% <100.00%> (ø)
...pl/voicemessages/timeline/VoiceMessagePresenter.kt	89.65% <100.00%> (+0.36%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

The apply is not necessary, I would simply write

errorTransform = {
    analyticsService.trackError(
        VoiceMessageException.PlayMessageError("Error while trying to play voice message", it)
    )
    it
},

to improve readability.

[julioromano]

I had it exactly like that before but it looked odd to my eyes so I switched to using apply 😆

[bmarty]

LGTM modulo a minor nit comment.

[julioromano]

LGTM modulo a minor nit comment.

Done

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information