Top bar in page #1670
Top bar in page #1670
Conversation
| scrollBehavior = scrollBehavior, | ||
| ) | ||
| } else { | ||
| Spacer(modifier = modifier.height(64.0.dp /* TopAppBarSmallTokens.ContainerHeight */)) |
There was a problem hiding this comment.
TopAppBarSmallTokens.ContainerHeight is internal, so cannot use it.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
| @@ -42,21 +45,26 @@ fun TopAppBar( | |||
| actions: @Composable RowScope.() -> Unit = {}, | |||
| windowInsets: WindowInsets = TopAppBarDefaults.windowInsets, | |||
| colors: TopAppBarColors = TopAppBarDefaults.topAppBarColors(), | |||
| scrollBehavior: TopAppBarScrollBehavior? = null | |||
| scrollBehavior: TopAppBarScrollBehavior? = null, | |||
| isVisible: Boolean = true, | |||
There was a problem hiding this comment.
This feels odd.
It shouldn't be the responsibility of any composable to provide a way to hide itself.
If you don't want it to be shown you should wrap it with an if just outside the point where you call it.
Maybe I didn't understand your intention here.
There was a problem hiding this comment.
You're right, I will update remove that.
bmarty
force-pushed
the
feature/bma/topBarInPage
branch
from
ab2a308
to
99fbb19
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1670 +/- ##
===========================================
- Coverage 63.24% 63.24% -0.01%
===========================================
Files 1230 1230
Lines 31753 31757 +4
Branches 6537 6539 +2
===========================================
+ Hits 20082 20084 +2
Misses 8667 8667
- Partials 3004 3006 +2
☔ View full report in Codecov by Sentry. |
Small PR to be able to add optional Back button in
HeaderFooterPage.Should not break any screenshot tests.