Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix voice message preview player playing after delete/send #1671

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Fix voice message preview player playing after delete/send #1671

merged 3 commits into from
Oct 27, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Prevent voice message preview playing after being deleted or sent.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 27, 2023 15:13
@jonnyandrew jonnyandrew requested review from bmarty and removed request for a team October 27, 2023 15:13
jonnyandrew
jonnyandrew commented Oct 27, 2023
View reviewed changes
...ain/kotlin/io/element/android/libraries/designsystem/components/media/FakeWaveformFactory.kt
@@ -20,17 +20,15 @@ import kotlinx.collections.immutable.ImmutableList
import kotlinx.collections.immutable.toPersistentList
import kotlin.random.Random

object FakeWaveformFactory {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR but addresses #1661 (comment)

bmarty
bmarty approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4844xm

@jonnyandrew jonnyandrew merged commit b046493 into develop Oct 27, 2023
15 checks passed
@jonnyandrew jonnyandrew deleted the jonny/voice-message-fixes branch October 27, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonnyandrew @bmarty