Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct icon tint in voice message preview player #1672

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Use correct icon tint in voice message preview player #1672

merged 2 commits into from
Oct 27, 2023

Conversation

julioromano
Copy link
Contributor

Action item from design review.

@julioromano julioromano self-assigned this Oct 27, 2023
@julioromano julioromano requested a review from a team as a code owner October 27, 2023 15:14
@julioromano julioromano requested review from jmartinesp and removed request for a team October 27, 2023 15:14
@julioromano julioromano mentioned this pull request Oct 27, 2023
Closed
6 tasks
@julioromano julioromano enabled auto-merge (squash) October 27, 2023 15:15
@julioromano
Copy link
Contributor Author

julioromano commented Oct 27, 2023 •
edited

Screenshots: https://github.com/vector-im/element-x-android/actions/runs/6669244028

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FipLnQ

jmartinesp
jmartinesp reviewed Oct 27, 2023
View reviewed changes
...s/ui_S_t[l.textcomposer.components_null_VoiceMessagePreview-D-16_16_null,NEXUS_5,1.0,en].png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite weird, now it looks as if it were always enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @callumu what d'you think?

...s/ui_S_t[l.textcomposer.components_null_VoiceMessagePreview-N-16_17_null,NEXUS_5,1.0,en].png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here every button looks disabled.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julioromano julioromano enabled auto-merge (squash) October 27, 2023 16:10
@julioromano julioromano mentioned this pull request Oct 27, 2023
Closed
6 tasks
@codecov
Copy link

codecov bot commented Oct 27, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@julioromano julioromano merged commit f3c4c62 into develop Oct 27, 2023
15 checks passed
@julioromano julioromano deleted the julioromano/composerIconColor branch October 27, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp left review comments

@jonnyandrew jonnyandrew jonnyandrew approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julioromano @jmartinesp @jonnyandrew @ElementBot