Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show voice message preview player progress #1675

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Display the progress bar while playing a voice message preview
  • Disable seeking the preview player while it is not yet implemented

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 27, 2023 16:22
@jonnyandrew jonnyandrew requested review from julioromano and removed request for a team October 27, 2023 16:22
@jonnyandrew jonnyandrew marked this pull request as draft October 27, 2023 16:23
@jonnyandrew jonnyandrew marked this pull request as ready for review October 27, 2023 16:33
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AXWZAb

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (21499a2) 63.69% compared to head (82ddbac) 63.25%.

❗ Current head 82ddbac differs from pull request most recent head 4b01565. Consider uploading reports for the commit 4b01565 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1675      +/-   ##
===========================================
- Coverage    63.69%   63.25%   -0.45%     
===========================================
  Files         1267     1230      -37     
  Lines        32798    31775    -1023     
  Branches      6795     6543     -252     
===========================================
- Hits         20892    20100     -792     
+ Misses        8772     8672     -100     
+ Partials      3134     3003     -131     
Files Coverage Δ
...messages/composer/VoiceMessageComposerPresenter.kt 93.22% <100.00%> (+0.11%) ⬆️
...t/android/libraries/mediaplayer/api/MediaPlayer.kt 100.00% <100.00%> (ø)
...roid/libraries/mediaplayer/test/FakeMediaPlayer.kt 95.45% <100.00%> (+0.71%) ⬆️
...ies/textcomposer/components/VoiceMessagePreview.kt 73.84% <100.00%> (+1.97%) ⬆️
.../libraries/textcomposer/model/VoiceMessageState.kt 100.00% <100.00%> (ø)
...android/libraries/mediaplayer/impl/SimplePlayer.kt 0.00% <0.00%> (ø)
...ent/android/libraries/textcomposer/TextComposer.kt 77.62% <66.66%> (+0.06%) ⬆️
...icemessages/composer/VoiceMessageComposerPlayer.kt 70.00% <66.66%> (+2.00%) ⬆️
...roid/libraries/mediaplayer/impl/MediaPlayerImpl.kt 0.00% <0.00%> (ø)
...ignsystem/components/media/WaveformPlaybackView.kt 67.05% <23.52%> (+1.20%) ⬆️

... and 66 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I've pushed a minor nit-fixing commit over your branch that touches on the few mediaplayer bits. I hope that's okay, sorry for not asking upfront.

@jonnyandrew
Copy link
Contributor Author

Not a problem - thanks for the improvements! :)

@jonnyandrew jonnyandrew enabled auto-merge (squash) October 27, 2023 20:04
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew merged commit 8121d1a into develop Oct 27, 2023
13 of 15 checks passed
@jonnyandrew jonnyandrew deleted the jonny/vm-preview-progress branch October 27, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants