Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Element Call integration in rooms by default #1685

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

jmartinesp
Copy link
Contributor

@jmartinesp jmartinesp commented Oct 30, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Enable Element Call integration in rooms by default.
  • Also change base url to call.element.dev.

Once we've confirmed it's been stable for a while we can probably remove the FF, but we should probably leave the FF there in case we need to release a hotfix disabling the feature.

Motivation and context

Enable this feature for all users.

Tests

  • Run the app.
  • If you hadn't manually disabled the FF before, you should be able to use the EC integration.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

Also change base url to `call.element.dev`.
@jmartinesp jmartinesp requested a review from a team as a code owner October 30, 2023 10:28
@jmartinesp jmartinesp requested review from julioromano and removed request for a team October 30, 2023 10:28
@jmartinesp jmartinesp enabled auto-merge (squash) October 30, 2023 10:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ndGxW4

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jmartinesp jmartinesp merged commit e64f822 into develop Oct 30, 2023
13 checks passed
@jmartinesp jmartinesp deleted the feature/jme/enable-element-call branch October 30, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants