Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add haptic feedback to voice message record button #1686

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add haptic feedback to voice message record button

Motivation and context

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 30, 2023 10:31
@jonnyandrew jonnyandrew requested review from bmarty and removed request for a team October 30, 2023 10:31
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XPxHXd

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9472081) 63.71% compared to head (7e69f7b) 63.70%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1686      +/-   ##
===========================================
- Coverage    63.71%   63.70%   -0.02%     
===========================================
  Files         1267     1267              
  Lines        32831    32840       +9     
  Branches      6802     6802              
===========================================
+ Hits         20919    20921       +2     
- Misses        8775     8782       +7     
  Partials      3137     3137              
Files Coverage Δ
.../libraries/textcomposer/components/RecordButton.kt 39.21% <41.66%> (-3.65%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyandrew jonnyandrew merged commit 18ca1da into develop Oct 30, 2023
13 of 16 checks passed
@jonnyandrew jonnyandrew deleted the jonny/vm-haptic-feedback branch October 30, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants