Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Strings #1687

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Sync Strings #1687

merged 1 commit into from
Oct 30, 2023

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot requested a review from a team as a code owner October 30, 2023 11:39
@ElementBot ElementBot requested review from jmartinesp and removed request for a team October 30, 2023 11:39
@bmarty
Copy link
Member

bmarty commented Oct 30, 2023

Will ask for a Frenchie to review this (translations are from me)

@bmarty bmarty removed the request for review from jmartinesp October 30, 2023 11:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tkxBSq

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1a3a80) 63.70% compared to head (ffd02b8) 63.70%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1687   +/-   ##
========================================
  Coverage    63.70%   63.70%           
========================================
  Files         1267     1267           
  Lines        32834    32834           
  Branches      6797     6797           
========================================
  Hits         20918    20918           
  Misses        8780     8780           
  Partials      3136     3136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElementBot ElementBot force-pushed the sync-localazy branch 2 times, most recently from 54b624c to dee2838 Compare October 30, 2023 13:57
@ElementBot
Copy link
Collaborator Author

ElementBot commented Oct 30, 2023

Warnings
⚠️

features/lockscreen/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

features/roomdetails/impl/src/main/res/values-cs/translations.xml#L3 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L203 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L208 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against ffd02b8

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarty bmarty merged commit a63cd90 into develop Oct 30, 2023
15 checks passed
@bmarty bmarty deleted the sync-localazy branch October 30, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants