Fix issues with stuck 'loading...' state and hangup #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Oct 30, 2023
| @@ -90,10 +94,19 @@ class CallScreenPresenter @AssistedInject constructor( | |||
| .onEach { | |||
| // Relay message to Widget Driver | |||
| callWidgetDriver.value?.send(it) | |||
| println(it) | |||
There was a problem hiding this comment.
Strange to see println here. Use Timber or remove the temporary log?
There was a problem hiding this comment.
Nice catch, I deleted a couple of other temporary logs, but I forgot about this one.
| @@ -59,6 +62,7 @@ class CallScreenPresenter @AssistedInject constructor( | |||
|
|
|||
| private val isInWidgetMode = callType is CallType.RoomCall | |||
| private val userAgent = userAgentProvider.provide() | |||
| private var joinedCall = false | |||
There was a problem hiding this comment.
Shouldn't this be a rememberSaveable?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1690 +/- ##
===========================================
- Coverage 63.70% 63.68% -0.03%
===========================================
Files 1267 1267
Lines 32834 32835 +1
Branches 6797 6796 -1
===========================================
- Hits 20918 20910 -8
- Misses 8780 8789 +9
Partials 3136 3136
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
extraCapacityto the flows that relay messages between the Widget and the Rust Widget Driver to make sure we don't drop any messages. This was causing a stuck 'Loading...' state to be shown from time to time.Motivation and context
Bugfixes.
Tested devices
Checklist