Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong CompoundColors mapping #1692

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix wrong CompoundColors mapping #1692

merged 2 commits into from
Oct 30, 2023

Conversation

julioromano
Copy link
Contributor

@julioromano julioromano self-assigned this Oct 30, 2023
@julioromano julioromano requested a review from a team as a code owner October 30, 2023 16:05
@julioromano julioromano requested review from ganfra and jmartinesp and removed request for a team and ganfra October 30, 2023 16:05
@julioromano
Copy link
Contributor Author

Screenshots: https://github.com/vector-im/element-x-android/actions/runs/6695523341

@julioromano
Copy link
Contributor Author

Whoever approves this: Please merge it right afterwards.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7hMqL5

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jmartinesp
jmartinesp approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmartinesp jmartinesp merged commit 609b100 into develop Oct 30, 2023
13 of 14 checks passed
@jmartinesp jmartinesp deleted the julioromano/fixCompound branch October 30, 2023 17:22
@julioromano
Copy link
Contributor Author

@callumu please have a look at how the screenshots in this PR have changed after the fix.

bmarty
bmarty reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, nice effect on the app! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty left review comments

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect figma style value bg.canvas.default
4 participants
@julioromano @jmartinesp @bmarty @ElementBot