Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra logs to help debug session restoration failures #1701

Merged

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Logs the error returned from the Rust SDK when the session can't be restored.

Motivation and context

This would make finding out the exact cause of restoration issues easier.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner October 31, 2023 09:51
@jmartinesp jmartinesp requested review from ganfra and removed request for a team October 31, 2023 09:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmartinesp jmartinesp enabled auto-merge (squash) October 31, 2023 09:58
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5f85707) 63.64% compared to head (e371a7f) 63.64%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1701   +/-   ##
========================================
  Coverage    63.64%   63.64%           
========================================
  Files         1267     1267           
  Lines        32881    32881           
  Branches      6809     6809           
========================================
  Hits         20928    20928           
  Misses        8805     8805           
  Partials      3148     3148           
Files Coverage Δ
...o/element/android/appnav/di/MatrixClientsHolder.kt 77.14% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rKCpj4

@jmartinesp jmartinesp merged commit 5757789 into develop Oct 31, 2023
14 of 16 checks passed
@jmartinesp jmartinesp deleted the misc/jme/add-extra-logs-for-session-restoration-failures branch October 31, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants