Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long press on voice message with screen reader #1704

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 31, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Fix long press on voice messages which was not working before this change.
  • Disable seeking within the voice message waveform (the workaround).

Motivation and context

  • [Story] Use timeline features for voice messages element-meta#2106
  • Long press menu is a core feature which must work for screen readers
  • Seek behaviour is a nice-to-have feature that is already sub-optimal for screen readers: there is no spoken feedback about the current seek position. No core functionality is lost as voice messages can still be played using a screen reader.

Screenshots / GIFs

Tests

  • Enable talkback
  • Long press on a message

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 31, 2023 10:55
@jonnyandrew jonnyandrew requested review from bmarty and julioromano and removed request for a team and bmarty October 31, 2023 10:55
@jonnyandrew jonnyandrew force-pushed the jonny/fix-vm-seek-vs-long-press branch from 07f8f3c to e5c86c3 Compare October 31, 2023 11:00
As a workaround, disable seeking within the waveform so that it does
not interfere with the long press menu.

Seeking behaviour is already suboptimal given that there is no spoken
feedback about the current seek position. No core functionality is
lost as voice messages can be played using a screen reader.
@jonnyandrew jonnyandrew force-pushed the jonny/fix-vm-seek-vs-long-press branch from e5c86c3 to c8eab7e Compare October 31, 2023 11:07
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ujr2jx

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (356a321) 63.68% compared to head (c8eab7e) 63.67%.
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1704      +/-   ##
===========================================
- Coverage    63.68%   63.67%   -0.01%     
===========================================
  Files         1267     1268       +1     
  Lines        32835    32841       +6     
  Branches      6796     6799       +3     
===========================================
+ Hits         20910    20912       +2     
- Misses        8789     8790       +1     
- Partials      3136     3139       +3     
Files Coverage Δ
...timeline/components/event/TimelineItemVoiceView.kt 62.50% <50.00%> (-0.30%) ⬇️
...libraries/androidutils/accessibility/ContextExt.kt 25.00% <25.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonnyandrew jonnyandrew merged commit 95a2152 into develop Oct 31, 2023
13 of 16 checks passed
@jonnyandrew jonnyandrew deleted the jonny/fix-vm-seek-vs-long-press branch October 31, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants