Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the logs for TimelineException.CannotPaginate #1708

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Log TimelineException.CannotPaginate exceptions as only debug messages without a stacktrace.
  • Any other exception thrown in RustMatrixTimeline.paginateBackwards will print the stacktrace and have a better error message.

Motivation and context

@jplatte complained these looked like Rust SDK issues and pollute the logs quite a bit.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner October 31, 2023 15:26
@jmartinesp jmartinesp requested review from ganfra and removed request for a team October 31, 2023 15:26
@jplatte
Copy link
Contributor

jplatte commented Oct 31, 2023

Thanks!

Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmartinesp jmartinesp enabled auto-merge (squash) October 31, 2023 15:37
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YLki7M

@jmartinesp jmartinesp merged commit 3bbaf8e into develop Oct 31, 2023
13 of 14 checks passed
@jmartinesp jmartinesp deleted the misc/jme/improve-back-pagination-error-logging branch October 31, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants