Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin unlock : implement design for in-app unlock #1714

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Pin unlock : implement design for in-app unlock #1714

merged 2 commits into from
Oct 31, 2023

Conversation

ganfra
Copy link
Contributor

@ganfra ganfra commented Oct 31, 2023 •
edited

Same as #1707 but fixing conflicts was longer than cherry picking the only relevant commit.

@ganfra ganfra marked this pull request as ready for review October 31, 2023 19:19
@ganfra ganfra requested a review from a team as a code owner October 31, 2023 19:19
@ganfra ganfra requested review from julioromano and jmartinesp and removed request for a team and julioromano October 31, 2023 19:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ganfra ganfra enabled auto-merge October 31, 2023 19:49
@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RmaaTt

jmartinesp
jmartinesp approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ganfra ganfra merged commit 46869b8 into develop Oct 31, 2023
13 of 15 checks passed
@ganfra ganfra deleted the feature/fga/unlock_settings_2 branch October 31, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ganfra @jmartinesp @ElementBot