Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flescio/add room image #961

Merged
merged 13 commits into from
May 30, 2023
Merged

Flescio/add room image #961

merged 13 commits into from
May 30, 2023

Conversation

flescio
Copy link
Contributor

@flescio flescio commented May 26, 2023

Resolve #664 and #665

Add the image picker flow for the creation of a room, the image is transformed into a MediaInfo for having the thumbnail and infos, the thumbnail is presented in the UI, the user has the liberty of removing it or change it.

When the user press the create button, the image will be uploaded and then the room will be created.

create room

@github-actions
Copy link

github-actions bot commented May 26, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e8ed3ac

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 8.00% and project coverage change: +1.46 🎉

Comparison is base (eba0fe5) 46.38% compared to head (3f97d14) 47.84%.

❗ Current head 3f97d14 differs from pull request most recent head e8ed3ac. Consider uploading reports for the commit e8ed3ac to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #961      +/-   ##
===========================================
+ Coverage    46.38%   47.84%   +1.46%     
===========================================
  Files          349      335      -14     
  Lines        22432    20889    -1543     
  Branches     12207    11450     -757     
===========================================
- Hits         10404     9994     -410     
+ Misses       11737    10614    -1123     
+ Partials       291      281      -10     
Flag Coverage Δ
unittests 22.57% <8.00%> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/Screens/CreateRoom/CreateRoomCoordinator.swift 0.00% <0.00%> (ø)
.../Sources/Screens/CreateRoom/CreateRoomModels.swift 100.00% <ø> (ø)
...ces/Screens/CreateRoom/View/CreateRoomScreen.swift 0.00% <0.00%> (ø)
...s/StartChatScreen/StartChatScreenCoordinator.swift 9.79% <0.00%> (-5.77%) ⬇️
ElementX/Sources/Services/Client/ClientError.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Client/ClientProxy.swift 38.71% <0.00%> (+1.82%) ⬆️
.../Sources/Services/Client/ClientProxyProtocol.swift 0.00% <ø> (ø)
...Services/CreateRoom/CreateRoomFlowParameters.swift 100.00% <ø> (ø)
...es/Services/Media/MediaUploadingPreprocessor.swift 71.47% <0.00%> (+1.24%) ⬆️
...urces/Screens/CreateRoom/CreateRoomViewModel.swift 42.96% <32.14%> (-7.04%) ⬇️

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flescio flescio marked this pull request as ready for review May 26, 2023 09:31
@flescio flescio requested a review from a team as a code owner May 26, 2023 09:31
@flescio flescio requested review from pixlwave and removed request for a team May 26, 2023 09:31
Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 📸

@flescio flescio requested a review from pixlwave May 26, 2023 14:52
Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flescio flescio enabled auto-merge (squash) May 30, 2023 12:41
@flescio flescio merged commit 03ba211 into develop May 30, 2023
6 checks passed
@flescio flescio deleted the flescio/add_room_image branch May 30, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select a media from camera
3 participants