-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flescio/add room image #961
Conversation
Generated by 🚫 Danger Swift against e8ed3ac |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #961 +/- ##
===========================================
+ Coverage 46.38% 47.84% +1.46%
===========================================
Files 349 335 -14
Lines 22432 20889 -1543
Branches 12207 11450 -757
===========================================
- Hits 10404 9994 -410
+ Misses 11737 10614 -1123
+ Partials 291 281 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition 📸
ElementX/Sources/Services/Media/MediaUploadingPreprocessor.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
Outdated
Show resolved
Hide resolved
7b197ad
to
e8ed3ac
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Resolve #664 and #665
Add the image picker flow for the creation of a room, the image is transformed into a MediaInfo for having the thumbnail and infos, the thumbnail is presented in the UI, the user has the liberty of removing it or change it.
When the user press the create button, the image will be uploaded and then the room will be created.