Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PostHog to fix Accent Colour bug. #1006

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Jun 2, 2023

Since enabling PostHog, there was an issue for users who had opted into Analytics where their accent colour was broken. This was addressed by PostHog so this PR updated the package to fix the colour.

Before After
IMG_4D84BB75FF73-1 Simulator Screenshot - iPhone 14 Pro - 2023-06-02 at 09 11 11

@pixlwave pixlwave requested a review from a team as a code owner June 2, 2023 08:14
@pixlwave pixlwave requested review from Velin92 and removed request for a team June 2, 2023 08:14
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against dbd4684

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave removed the request for review from Velin92 June 2, 2023 08:34
@pixlwave pixlwave merged commit 0972af3 into develop Jun 2, 2023
5 of 6 checks passed
@pixlwave pixlwave deleted the doug/accent-colour branch June 2, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants