Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the background colour when replying. #1007

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Jun 2, 2023

Fix an incorrect colour:

Before After
Simulator Screenshot - iPhone 14 Pro - 2023-06-02 at 09 35 52 Simulator Screenshot - iPhone 14 Pro - 2023-06-02 at 09 34 59

@pixlwave pixlwave requested a review from a team as a code owner June 2, 2023 08:37
@pixlwave pixlwave requested review from stefanceriu and removed request for a team June 2, 2023 08:37
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d6fe550

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.15 🎉

Comparison is base (dcc4ea5) 46.56% compared to head (d6fe550) 46.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1007      +/-   ##
===========================================
+ Coverage    46.56%   46.71%   +0.15%     
===========================================
  Files          349      349              
  Lines        22802    22802              
  Branches     12310    12310              
===========================================
+ Hits         10617    10653      +36     
+ Misses       11886    11849      -37     
- Partials       299      300       +1     
Flag Coverage Δ
unittests 23.72% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rces/Screens/RoomScreen/View/MessageComposer.swift 31.88% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave merged commit 07927c3 into develop Jun 2, 2023
10 checks passed
@pixlwave pixlwave deleted the doug/reply-colour branch June 2, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants