Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim newlines from message previews. #1208

Merged
merged 3 commits into from Jun 29, 2023
Merged

Conversation

pixlwave
Copy link
Contributor

  • Fixes a bug with replies where the message shows on the line after the sender's name.

This is the simple fix although I we should discuss whether it would make more sense to strip markdown from the preview by building the attributed string from the formatted body to get a clean string instead.

Before After
Simulator Screenshot - iPhone 14 - 2023-06-28 at 18 32 12 Simulator Screenshot - iPhone 14 - 2023-06-28 at 18 31 43

@pixlwave pixlwave requested a review from a team as a code owner June 28, 2023 17:35
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against f3ecf63

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.26 🎉

Comparison is base (98cec56) 41.11% compared to head (ad4c5ea) 41.37%.

❗ Current head ad4c5ea differs from pull request most recent head f3ecf63. Consider uploading reports for the commit f3ecf63 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1208      +/-   ##
===========================================
+ Coverage    41.11%   41.37%   +0.26%     
===========================================
  Files          413      410       -3     
  Lines        26459    26305     -154     
  Branches     13683    13621      -62     
===========================================
+ Hits         10879    10885       +6     
+ Misses       15286    15126     -160     
  Partials       294      294              
Flag Coverage Δ
unittests 23.39% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 4.61% <0.00%> (-0.08%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

we should discuss whether it would make more sense to strip markdown from the preview by building the attributed string from the formatted body to get a clean string instead

It makes sense to me but it's a product decision in the end

- Fixes a bug with replies where the message shows on the line after the sender's name.
@pixlwave pixlwave enabled auto-merge (squash) June 29, 2023 09:51
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave disabled auto-merge June 29, 2023 10:34
@pixlwave pixlwave merged commit ba79d7f into develop Jun 29, 2023
5 of 6 checks passed
@pixlwave pixlwave deleted the doug/room-list-previews branch June 29, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants