New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim newlines from message previews. #1208
Conversation
Generated by 🚫 Danger Swift against f3ecf63 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1208 +/- ##
===========================================
+ Coverage 41.11% 41.37% +0.26%
===========================================
Files 413 410 -3
Lines 26459 26305 -154
Branches 13683 13621 -62
===========================================
+ Hits 10879 10885 +6
+ Misses 15286 15126 -160
Partials 294 294
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
we should discuss whether it would make more sense to strip markdown from the preview by building the attributed string from the formatted body to get a clean string instead
It makes sense to me but it's a product decision in the end
ElementX/Sources/Services/Room/RoomSummary/RoomEventStringBuilder.swift
Outdated
Show resolved
Hide resolved
- Fixes a bug with replies where the message shows on the line after the sender's name.
25d8ca2
to
ad4c5ea
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This is the simple fix although I we should discuss whether it would make more sense to strip markdown from the preview by building the attributed string from the formatted body to get a clean string instead.