Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default media upload file mime types to application/octet-stream so… #1385

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Default media upload file mime types to application/octet-stream so… #1385

merged 1 commit into from
Jul 24, 2023

Conversation

stefanceriu
Copy link
Contributor

… that uploading doesn't fail rust side

Fixes problems in uploading less common file types like dmg, apk etc.

@stefanceriu stefanceriu requested a review from a team as a code owner July 24, 2023 06:57
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team July 24, 2023 06:57
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 06c9fe0

pixlwave
pixlwave approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh! Wonder if we should make mimeType non-optional on the Rust side then? Or nil coalesce to octet-stream in Rust? Seems pointless allowing it to accept something that will fail.

@stefanceriu
Copy link
Contributor Author

Seems pointless allowing it to accept something that will fail.
The main reason for not doing it like that to being with was that the MediaInfo types are reused for received media too and those do have these fields as optionals.

@stefanceriu stefanceriu merged commit de19938 into develop Jul 24, 2023
5 of 6 checks passed
@stefanceriu stefanceriu deleted the stefan/fixMediaUploadMissingMimeTypes branch July 24, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanceriu @pixlwave