Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit the room Notification setting #1394

Merged
merged 10 commits into from
Jul 26, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jul 25, 2023

This PR implements #1004 to define the notification setting for a room.

@nimau nimau requested a review from a team as a code owner July 25, 2023 09:47
@nimau nimau requested review from alfogrillo and removed request for a team July 25, 2023 09:47
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3c8ab5b

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 38.00% and project coverage change: +0.67% 🎉

Comparison is base (9f4479b) 44.83% compared to head (3c8ab5b) 45.50%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1394      +/-   ##
===========================================
+ Coverage    44.83%   45.50%   +0.67%     
===========================================
  Files          389      394       +5     
  Lines        24886    25153     +267     
  Branches     12694    12838     +144     
===========================================
+ Hits         11157    11446     +289     
+ Misses       13445    13418      -27     
- Partials       284      289       +5     
Flag Coverage Δ
unittests 23.15% <37.38%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Application/AppSettings.swift 96.15% <ø> (ø)
...mentX/Sources/Other/AccessibilityIdentifiers.swift 97.01% <0.00%> (-1.47%) ⬇️
...omDetailsScreen/RoomDetailsScreenCoordinator.swift 11.76% <0.00%> (-0.40%) ⬇️
...en/RoomNotificationSettingsScreenCoordinator.swift 0.00% <0.00%> (ø)
...gsScreen/View/RoomNotificationSettingsScreen.swift 0.00% <0.00%> (ø)
...erOptionsScreen/DeveloperOptionsScreenModels.swift 0.00% <ø> (ø)
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% <ø> (ø)
ElementX/Sources/Services/Client/ClientProxy.swift 0.00% <0.00%> (ø)
.../Sources/Services/Client/ClientProxyProtocol.swift 0.00% <ø> (ø)
...tificationSettings/NotificationSettingsProxy.swift 0.00% <0.00%> (ø)
... and 6 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimau nimau force-pushed the nicolas/1004-edit-room-notification-settings branch from e895ed9 to b61a464 Compare July 25, 2023 13:35
Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments looking at the use of Compound :)

Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tweaks, looks good to me from the perspective of Compound 👍

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nimau nimau enabled auto-merge (squash) July 26, 2023 08:14
@nimau nimau disabled auto-merge July 26, 2023 09:05
@nimau nimau force-pushed the nicolas/1004-edit-room-notification-settings branch from 51593bc to 3c8ab5b Compare July 26, 2023 09:09
@nimau nimau enabled auto-merge (squash) July 26, 2023 09:23
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nimau nimau merged commit ed68ed1 into develop Jul 26, 2023
10 checks passed
@nimau nimau deleted the nicolas/1004-edit-room-notification-settings branch July 26, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants