Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"View only" polls in the timeline #1399

Merged
merged 17 commits into from
Jul 27, 2023
Merged

"View only" polls in the timeline #1399

merged 17 commits into from
Jul 27, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Jul 25, 2023

This PR renders the polls created with other clients.

Notes

  • The design isn't final yet
  • The poll component isn't interactive (votes cannot be submitted)
  • Actions on the poll events need to be implemented/refined
  • ⚠️ More work is required in the matrix-rust-sdk to be able to see the polls in the timeline. The screenshots are real, but they have been taken while using a custom development branch for the matrix-rust-sdk.

iPhone

Bubbles Modern
b1 m_i

iPad

Bubbles Modern
b2 m_t

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a6a295a

@alfogrillo alfogrillo self-assigned this Jul 25, 2023
@alfogrillo alfogrillo changed the title View only polls in the timeline "View only" polls in the timeline Jul 26, 2023
@alfogrillo alfogrillo force-pushed the alfogrillo/polls branch 2 times, most recently from bec4907 to 6a13ecd Compare July 27, 2023 10:36
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 0.51% and project coverage change: -0.20% ⚠️

Comparison is base (8f29047) 45.80% compared to head (a6a295a) 45.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1399      +/-   ##
===========================================
- Coverage    45.80%   45.60%   -0.20%     
===========================================
  Files          394      396       +2     
  Lines        25510    25667     +157     
  Branches     12974    13027      +53     
===========================================
+ Hits         11684    11706      +22     
- Misses       13531    13666     +135     
  Partials       295      295              
Flag Coverage Δ
unittests 22.93% <0.51%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Application/AppSettings.swift 96.15% <ø> (ø)
...s/Other/SwiftUI/Form Styles/FormButtonStyles.swift 39.64% <0.00%> (-0.60%) ⬇️
...een/View/Style/TimelineItemBubbledStylerView.swift 59.41% <0.00%> (-3.28%) ⬇️
...eens/RoomScreen/View/Timeline/PollOptionView.swift 0.00% <0.00%> (ø)
...oomScreen/View/Timeline/PollRoomTimelineView.swift 0.00% <0.00%> (ø)
...erOptionsScreen/DeveloperOptionsScreenModels.swift 0.00% <ø> (ø)
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% <0.00%> (ø)
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 0.00% <0.00%> (ø)
...meline/TimelineItems/RoomTimelineItemFactory.swift 1.23% <0.00%> (-0.15%) ⬇️
.../Timeline/TimelineItems/RoomTimelineItemView.swift 60.93% <0.00%> (-1.97%) ⬇️
... and 1 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo marked this pull request as ready for review July 27, 2023 10:58
@alfogrillo alfogrillo requested a review from a team as a code owner July 27, 2023 10:58
@alfogrillo alfogrillo requested review from Velin92 and removed request for a team July 27, 2023 10:58
Copy link
Contributor

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo merged commit 0e7a48d into develop Jul 27, 2023
10 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/polls branch July 27, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants