Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification settings screen #1414

Merged
merged 2 commits into from Jul 31, 2023
Merged

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jul 27, 2023

This PR implements #1024 and #1025

Notes:

@nimau nimau requested a review from a team as a code owner July 27, 2023 14:55
@nimau nimau requested review from Velin92 and removed request for a team July 27, 2023 14:55
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 6185d8a

@nimau nimau requested review from pixlwave and removed request for Velin92 July 27, 2023 15:00
Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@nimau nimau requested a review from pixlwave July 28, 2023 16:15
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 40.63% and project coverage change: -8.86% ⚠️

Comparison is base (62f78fb) 54.31% compared to head (2c6ae72) 45.45%.

❗ Current head 2c6ae72 differs from pull request most recent head 6185d8a. Consider uploading reports for the commit 6185d8a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1414      +/-   ##
===========================================
- Coverage    54.31%   45.45%   -8.86%     
===========================================
  Files          393      396       +3     
  Lines        25413    25899     +486     
  Branches     12881    13137     +256     
===========================================
- Hits         13802    11772    -2030     
- Misses       11247    13826    +2579     
+ Partials       364      301      -63     
Flag Coverage Δ
unittests 22.93% <40.63%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../FlowCoordinators/UserSessionFlowCoordinator.swift 34.09% <0.00%> (-16.05%) ⬇️
...Screen/NotificationSettingsScreenCoordinator.swift 0.00% <0.00%> (ø)
...ttingsScreen/View/NotificationSettingsScreen.swift 0.00% <0.00%> (ø)
...ngs/SettingsScreen/SettingsScreenCoordinator.swift 9.37% <0.00%> (+0.09%) ⬆️
...tingsScreen/NotificationSettingsScreenModels.swift 53.33% <28.57%> (-21.67%) ⬇️
...gsScreen/NotificationSettingsScreenViewModel.swift 84.82% <84.48%> (+3.87%) ⬆️

... and 84 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nimau nimau force-pushed the nicolas/1024-notification-settings branch from 2c6ae72 to 6185d8a Compare July 31, 2023 08:56
@nimau nimau enabled auto-merge (squash) July 31, 2023 08:57
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nimau nimau merged commit d38b6f7 into develop Jul 31, 2023
6 checks passed
@nimau nimau deleted the nicolas/1024-notification-settings branch July 31, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants